search

google / tarpc

An RPC framework for Rust with a focus on ease of use.
MIT License
3.09k stars 189 forks source link

Allow to create tarpc server on existing listener #411

Closed SabatierBoris closed 6 months ago

SabatierBoris commented 7 months ago

When you want to use systemd.socket or systemfd for allocate the socket (TCP or UNIX) you need to be able to create a server on already existing listener

google-cla[bot] commented 7 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tikue commented 6 months ago

Thanks, and apologies for the review delay! Can you add unit tests for the new functions? Other than that, looks great.

SabatierBoris commented 6 months ago

Thanks, and apologies for the review delay! Can you add unit tests for the new functions? Other than that, looks great.

Hi, no problem.

I add some tests based on existing TCP and UDS tests.