search

google / tarpc

An RPC framework for Rust with a focus on ease of use.
MIT License
3.18k stars 194 forks source link

close request receiving channel on errors immediately #416

Closed altkdf closed 8 months ago

altkdf commented 8 months ago

Fixes the problem described in https://github.com/google/tarpc/issues/415.

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

altkdf commented 8 months ago

I signed the CLA but don't know how to rerun the CLA job.

altkdf commented 8 months ago

Clicking "rescan" gives me a "400. That’s an error. That’s all we know."

tikue commented 8 months ago

Obsoleted by https://github.com/google/tarpc/pull/423. Thanks so much for identifying this problem as well as the solution!