Closed OMGeeky closed 5 months ago
Thank you!
I Added some more and I think I found everything that I missed in the previous one.
I did find some more, like the unreachable macro. I found an easy way to check for this and will create a test that checks for any external usages.
One thing I also changed was all the usages of tarpc
to ::tarpc
because if you rename your import you can still access it with those two ::
in front of the crate name, by the name it was under originally.
Thanks so much for fixing this!
Directly using things like Result and Option without namespace inside the generated code without using the full namespace can lead to problems when the caller has renamed those usages and provided his own with different signatures (often done with the Result type).
See the Rust Reference on this.
One example that would create compiler errors without this fix: