search

google / tcmalloc

Apache License 2.0
4.41k stars 480 forks source link

missing-field-initializer #243

Closed torshepherd closed 4 months ago

torshepherd commented 4 months ago

I'm getting this error when compiling tcmalloc with -Werror:

tcmalloc/tcmalloc/huge_page_filler.h:763:31: error: missing initializer for member '...::TryGetResult::from_released' [-Werror=missing-field-initializers]
  763 |     return {nullptr, PageId{0}};

Should that field be false or true here?

torshepherd commented 4 months ago

Thanks for the speedy fix! There's a bunch more missing-field-init warnings elsewhere; can I put up a PR similarly fixing them?