Support Windows OS by using findstr for grep feature.

google / tern-closure

A Tern plugin adding Closure support.

Apache License 2.0

32 stars 18 forks source link

Support Windows OS by using findstr for grep feature. #1

Closed angelozerr closed 10 years ago

angelozerr commented 10 years ago

This PR gives the capability to use tern-closure with Windows OS (tested With Windows 7 64 bits) by using findstr (instead of using grep) inside grep.js if OS is Windows.

wesalvaro commented 10 years ago

LGTM.

jgiles commented 10 years ago

For the absolute vs relative path issue, what's the reason that the path.resolve call doesn't work? https://github.com/angelozerr/tern-closure/blob/master/lib/finder/grep.js#L87

angelozerr commented 10 years ago

Hi @jgiles I think you can close this issue. I have created the new PR https://github.com/google/tern-closure/pull/26 which fixes problem with Windows dir option. Hope you will accept it.