google / testrun

A tool to automate verification of network-based device behavior
Apache License 2.0
26 stars 9 forks source link

365978129: (feat) add PDF report templates #801

Closed OlgaMardvilko closed 1 month ago

OlgaMardvilko commented 1 month ago

Overview

Ticket: 365978129 feat: add PDF report templates

Changes applied to PDF reports in scope of this ticket:

Screenshots after changes

Pilot PDF

https://screenshot.googleplex.com/9WBNKfzT5nCzsU8 https://screenshot.googleplex.com/eiJHYeNNoeaqnK5

Qualification PDF

https://screenshot.googleplex.com/BxNC3Rt9UdFZmfR https://screenshot.googleplex.com/c7Bxo47NwSDH6os

jboddey commented 1 month ago

@OlgaMardvilko Could you add some screenshots of any report changes to the PR please?

OlgaMardvilko commented 1 month ago

@OlgaMardvilko Could you add some screenshots of any report changes to the PR please?

Hi @jboddey The description is updated with screenshots. Please check. Thank you!

jboddey commented 1 month ago

I'm getting the following error when running with a pilot device: https://paste.googleplex.com/5557419687280640

OlgaMardvilko commented 1 month ago

I'm getting the following error when running with a pilot device: https://paste.googleplex.com/5557419687280640

Right. This PR do not contain the final implementation. Here is only the html structure example with necessary classes + styles applied to it. So, we have two tickets (FE + BE). Here only the FE part and @hitnik will apply necessary BE changes to finalize the feature.

OlgaMardvilko commented 1 month ago

I'm getting the following error when running with a pilot device: https://paste.googleplex.com/5557419687280640

Hi @jboddey, the PR is updated: the current report template kept as is (not to break the current flow) and the new one is created to proceed with BE changes. FYI: @hitnik