search

google / testrun

A tool to automate verification of network-based device behavior
Apache License 2.0
28 stars 9 forks source link

Error handling for connection module #960

Closed MariusBaldovin closed 1 week ago

MariusBaldovin commented 2 weeks ago

Added error handling if GRPC server can't start due to port 5001 being blocked by UFW firewall.

BEFORE

Module.log Error_dhcp_before

Report report_dhcp_ip_before

AFTER

Module.log dhcp_error_handling_after

Report 1conn_before 1conn_before1

jhughesbiot commented 1 week ago

I think the check firewall comments should be moved into the recommendations section of the test config rather than report it in the results.

jboddey commented 1 week ago

I think the check firewall comments should be moved into the recommendations section of the test config rather than report it in the results.

@jhughesbiot I agree, though I think we should cover that in a another PR as a separate feature (enabling steps to resolve for error results).

MariusBaldovin commented 1 week ago

Removed "Check the firewall" message from the report