google / textfsm

Python module for parsing semi-structured text into python tables.
Apache License 2.0
1.11k stars 171 forks source link

textfsm_test: do not relay on dic order #33

Closed aplanas closed 6 years ago

aplanas commented 6 years ago

The test testNestedMatching compares a list of dictionaries with a string. In Python 2 (and some versions of Python 3) the order of a dictionary is not guaranteed, and this makes the test to fail.

This patch compares the raw result with the raw list, and assetEqual takes care of the ordering.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
aplanas commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!