google / timesketch

Collaborative forensic timeline analysis
Apache License 2.0
2.62k stars 589 forks source link

End2End tests fail: pyyaml _DeprecatedConfig #2848

Closed jaegeral closed 1 year ago

jaegeral commented 1 year ago

The automatic tests currently fail, it appears because of https://github.com/yaml/pyyaml/issues/724

We get

Collecting PyYAML==5.4.1 (from -r requirements.txt (line 22))
  Downloading PyYAML-5.4.1.tar.gz (175 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 175.1/175.1 kB 48.4 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [62 lines of output]
      /tmp/pip-build-env-70vln7z3/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
      !!

              ********************************************************************************
              The license_file parameter is deprecated, use license_files instead.

              By 2023-Oct-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.

              See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
              ********************************************************************************

      !!

Potential solution might be to switch to pyyaml 6.0, not sure if it would break other things.

jkppr commented 1 year ago

So bumping PyYAML to 6.0 does fix the PyLinter tests. (#2852 )

However, the frontend tests are still failing, since we are running on a deprecated node version (14). See #2718 Error:

warning url-loader@1.1.2: Invalid bin field for "url-loader".
error commander@11.0.0: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.21.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
Error: Process completed with exit code 1.

My interpretation of this error is, that commander@11.0.0 does not run with node 14 anymore. And since we are still on node 14, it errors out.