search

google / timesketch

Collaborative forensic timeline analysis
Apache License 2.0
2.62k stars 589 forks source link

[cli] wrong order of parameters #2862

Closed jaegeral closed 1 year ago

jaegeral commented 1 year ago

https://github.com/google/timesketch/blob/b9b2972986ce299f34c1867501fe906829191a68/cli_client/python/timesketch_cli_client/commands/attribute.py#L74

sketch.add_attribute(name, ontology, value) is the wrong order of parameters. https://github.com/google/timesketch/blob/b9b2972986ce299f34c1867501fe906829191a68/api_client/python/timesketch_api_client/sketch.py#L268

it should be name, value, ontology instead