google / timesketch

Collaborative forensic timeline analysis
Apache License 2.0
2.58k stars 589 forks source link

Event attribute include / exclude filters #2888

Closed jkppr closed 1 year ago

jkppr commented 1 year ago

This PR ports over the include & exclude feature for event attributes from the old UI. It also updates the formatting and handling of search queries when filter chips are applied.

image

I think this should close the issue below: closes #2573

berggren commented 1 year ago

Functionality looks good. Some UX ideas:

The + and - signs in the filter chips are a bit confusing. It feels like you shpuld click them. I opt to change this. Remove the icon for "include filters" and add a red text "Not" for exxlude filters. See how this is done in Opensearch dashboards:

Screenshot 2023-09-12 at 15 03 20

Something like this in TS:

Screenshot 2023-09-12 at 15 00 32

For the icons in the event detail view I opt to change them to magnify-minus-outline and magnify-plus-outline

Screenshot 2023-09-12 at 14 56 32

WDYT?

jkppr commented 1 year ago

Functionality looks good. Some UX ideas:

The + and - signs in the filter chips are a bit confusing. It feels like you shpuld click them. I opt to change this. Remove the icon for "include filters" and add a red text "Not" for exxlude filters. See how this is done in Opensearch dashboards:

For the icons in the event detail view I opt to change them to magnify-minus-outline and magnify-plus-outline

WDYT?

Thanks for the input. I like the idea with the red NOT and will include it.

About the magnify-minus-outline icons I'm a bit torn. They make sense from the "search" perspective. But the plus and minus are suuuper small and hard to distinguish if you have a good resolution screen (and don't zoom 200%), which is difficult from an accessibility point of view. I personally like the clean +/- icons. Looks modern and easy to distinguish to me. I could also imagine mdi-filter-plus-outline working, since the + and - are a bit larger. What do you think?

berggren commented 1 year ago

SG, as discussed offline - let's use the filter icons instead.