search

google / timesketch

Collaborative forensic timeline analysis
Apache License 2.0
2.58k stars 589 forks source link

Add Timeline, SearchIndex and Datasource creation to client api #2919

Open Tijnoz opened 1 year ago

Tijnoz commented 1 year ago

This PR splits out the code to create the timeline, searchindex and datasource in the generate_timeline_from_es_index function so they can be called directly as well, which supports different usecases as described in #2918.

I'll reiterate: Happy to amend if this is not in line with the codebase, or go at this a different way!

closes #2918

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Tijnoz commented 11 months ago

@jaegeral I have amended the code to conform to the pylint spec (based on the error it gave before). Hope you can rerun the workflows for me.