Added check to invalid API endpoints to close issue #3005

google / timesketch

Collaborative forensic timeline analysis

Apache License 2.0

2.58k stars 589 forks source link

Added check to invalid API endpoints to close issue #3005 #3058

Closed TedmanNguyen closed 4 months ago

TedmanNguyen commented 6 months ago

This PR improves accessing URL to return 404 for with invalid endpoint instead of 200.

Added handle_invalid_routes (in app.py) and unit test: InvalidResourceTest (in resources_test.py)

Checks

[x] All tests succeed.
[x] Unit tests added.
[ ] e2e tests added.
[ ] Documentation updated.

Closes issue #3005:

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mistic01 commented 5 months ago

Code Fix is working as expected - LGTM