google / timesketch

Collaborative forensic timeline analysis
Apache License 2.0
2.52k stars 577 forks source link

API Search Client max entries bug and standardize property usage #3101

Closed jawilson0502 closed 3 weeks ago

jawilson0502 commented 1 month ago

IMPORTANT: All Pull Requests should be connected to an issue, if you don't have an issue, please start by creating an issue and link it to the PR.

Please provide enough information so that others can review your pull request: Fixes issue: #3100

There is currently a bug in how max_entries is set in the from_manual function, causing the query_filter not to be set properly. I've also standardized a bit more to use the explicitly create properties, as I believe those were intended to be used over the _propertyNames ones.

Checks

Closing issues Closes #3100