google / trace-viewer

https://github.com/catapult-project/catapult/tree/master/tracing#readme
487 stars 84 forks source link

Flow IDs are not unique and some "f" flows do not have matching "s" phase and vice versa #1161

Closed yuhao closed 9 years ago

yuhao commented 9 years ago

I reported it on Chromium code review, but thought it was worth cross-posting it here.

https://code.google.com/p/chromium/issues/detail?id=515720

yuhao commented 9 years ago

@natduca

yuhao commented 9 years ago

A few more investigations.

  1. There is always only one repeated ID, with the name "TaskQueueManager::PostTask".
  2. The repeated ID is used as the "s" phase (flow producer).
  3. For those "f" phase flows that do not have a matching "s" phase, seems like they should have been matched by the repeated ID.
natduca commented 9 years ago

Did reverting the patch that @skyostil mentioned help?

yuhao commented 9 years ago

Automatic revert didn't work. Seems like a fix of that is forthcoming. If that doesn't happen today I will try to manually revert it (with care).

catapult-bot commented 9 years ago

Migrated to https://github.com/catapult-project/catapult/issues/1161