search

google / trace-viewer

https://github.com/catapult-project/catapult/tree/master/tracing#readme
487 stars 84 forks source link

Update namespaces given new core/ and non-core directory structure #699

Closed natduca closed 9 years ago

natduca commented 9 years ago

Care of #693, we have core and extras. We have base/.

But, we have some stuff in tv, some stuff in tracing. What's the right route forward?

dj2 commented 9 years ago

Personally, I like tv for trace-viewer. It's shorter then tracing and closer to the actual name of the project.

natduca commented 9 years ago

That seems promising!

Would rename toplevel folder to be tv? Then you'd have tv.base == tv/base.html, tv.TraceViewer == tv/trace_viewer.html etc

Would core/foo be tv.core.foo?

Would extras/ get prefixed with tv.extras?

dj2 commented 9 years ago

I think that all makes sense but core/foo would be tv.core.foo yea?

natduca commented 9 years ago

Derp, yes. I edited my previous post to reflect that. :)

natduca commented 9 years ago

Mostly done except for base. I've called tv/extras/ the tv.e namespace, so tv/base can be tv.b. That'll be my next CL.

natduca commented 9 years ago

Fixed in 5f648c3d0bc33e75de2b8a078b4878c7a016b95e