search

google / traceur-compiler

Traceur is a JavaScript.next-to-JavaScript-of-today compiler
Apache License 2.0
8.18k stars 580 forks source link

Refactor member variable transformer #1953

Closed arv closed 9 years ago

arv commented 9 years ago

This removes the member variable transformer logic from the class transformer in favor of reusing the old ES6ClassTransformer.

arv commented 9 years ago

@johnjbarton PTAL

The diff looks a lot larger because of the file renames. I can rename it back the old file names for the sake of the review if you prefer?

@vicb FYI

johnjbarton commented 9 years ago

What would help the most is more/different commit description. For example, "reusing the old ES6ClassTransformer" seems to conflict with that file being deleted.

arv commented 9 years ago

PTAL

I split it into 2 commits. The second one is pure rename and can mostly be ignored when reviewing.

I changed the commit message slightly:

Refactor member variable transformer

This removes the member variable transformer logic from
ClassTransformer. Instead we use the alrady existing
ES6ClassTransformer which does this as a stand alone transformer.
johnjbarton commented 9 years ago

LGTM but the change to the test case seems suspicious.