search

google / traceur-compiler

Traceur is a JavaScript.next-to-JavaScript-of-today compiler
Apache License 2.0
8.18k stars 580 forks source link

Fixes issue for inline ES6 `export *` imports #1985

Closed pflannery closed 8 years ago

pflannery commented 9 years ago

When supplying --modules=inline --outputLanguage=es6 to the cli, any imported export * from ... statements were referencing the es5 $traceurRuntime.exportStar function.

closes #1842

pflannery commented 9 years ago

@arv i've generated the loop inline using gensym as requested. PTAL

arv commented 9 years ago

@johnjbarton Can you take a look? I'm out for two weeks.

johnjbarton commented 9 years ago

Yes, I will look on Sunday.

johnjbarton commented 9 years ago

Can we add a test case that fails before and succeeds after this fix? The code itself looks good.

pflannery commented 9 years ago

@johnjbarton I finally figured out how to test export * statements using code generation. PTAL at the new unit test I've added.

pflannery commented 9 years ago

@johnjbarton I've got the test to pass without having to convert the expected code output in to a tree and back again. I've also wrapped the long line when creating the InlineES6ModuleTransformer. PTAL

johnjbarton commented 9 years ago

LGTM I'll merge it, Thanks!

arv commented 8 years ago

I merged this.

@pflannery Sorry about forgetting this.