google / traceur-compiler

Traceur is a JavaScript.next-to-JavaScript-of-today compiler
Apache License 2.0
8.17k stars 580 forks source link

Implement __moduleName second argument to System.register #2043

Closed guybedford closed 8 years ago

guybedford commented 8 years ago

See https://github.com/systemjs/builder/issues/416 for the discussion here.

arv commented 8 years ago

Can this be tested?

becky7 commented 8 years ago

HI IS BECKY

guybedford commented 8 years ago

Sure, I've included a test.

guybedford commented 8 years ago

I've also added an adjustment to only output the __moduleName argument when it is needed.

arv commented 8 years ago

Overall looking good. Just a few nits and it is good to go.

guybedford commented 8 years ago

Sure thanks, I've updated the PR.

arv commented 8 years ago

Committed as 03605414e9c97d6b69e01365c2b8ea4fae48744c