search

google / traceur-compiler

Traceur is a JavaScript.next-to-JavaScript-of-today compiler
Apache License 2.0
8.18k stars 578 forks source link

Travis CI: Test on Node.js v4.x.x and v5.x.x #2050

Closed SrinivasanTarget closed 8 years ago

arv commented 8 years ago

What is the motivation of this? I can see a few reasons but I would like to know yours?

The downside of doing this is that it takes longer before we know the results...

SrinivasanTarget commented 8 years ago

@arv I don't think it will take sometime to know the results as CI took very less time to update the results back. Also i feel it would be always great to test features not only on latest stable version and also the stable versions that are widely used. Please let me know your thoughts.

SrinivasanTarget commented 8 years ago

@arv ping

arv commented 8 years ago

LGTM

@SrinivasanTarget Did you sign the CLA? Can you add yourself to AUTHORS?

@johnjbarton Can you check the clasigners (I can no longer access it)?

SrinivasanTarget commented 8 years ago

Please let me know how to sign CLA? On 18-Jan-2016 6:27 am, "Erik Arvidsson" notifications@github.com wrote:

LGTM

@SrinivasanTarget https://github.com/SrinivasanTarget Did you sign the CLA? Can you add yourself to AUTHORS?

@johnjbarton https://github.com/johnjbarton Can you check the clasigners (I can no longer access it)?

— Reply to this email directly or view it on GitHub https://github.com/google/traceur-compiler/pull/2050#issuecomment-172402346 .

arv commented 8 years ago

Instructions are here: https://github.com/google/traceur-compiler/blob/master/CONTRIBUTING.md

SrinivasanTarget commented 8 years ago

I have signed the CLA.

SrinivasanTarget commented 8 years ago

@arv @johnjbarton updated in author list as well.

arv commented 8 years ago

LGTM

SrinivasanTarget commented 8 years ago

@arv @johnjbarton Can you merge ?