search

google / tracing-framework

Web Tracing Framework libraries and extensions.
http://google.github.io/tracing-framework/
BSD 3-Clause "New" or "Revised" License
2.65k stars 200 forks source link

Chrome sad tab in hud/settings/providers #517

Open rsturgell opened 9 years ago

rsturgell commented 9 years ago

If the debugger provider is enabled (yellow '"Web Tracing Framework" is debugging this tab.' bar) then opening "Settings" from the hud and selecting "Providers" crashes chrome (sad tab).

The workaround is is to click "cancel" in the yellow bar (or open the chrome debugger to steal the debugging session) and then go into settings and disable the "Chrome Debugging" provider.

Repros on Chrome 37 (release channel) on linux and mac, seems to NOT repro on Chrome 39 (canary) mac. Haven't tried anything in between yet.

benvanik commented 9 years ago

Wow, that's messed up. Wonder what could be causing that - maybe some weird recursion?

On Fri Sep 26 2014 at 9:53:09 AM rsturgell notifications@github.com wrote:

If the debugger provider is enabled (yellow '"Web Tracing Framework" is debugging this tab.' bar) then opening "Settings" from the hud and selecting "Providers" crashes chrome (sad tab).

The workaround is is to click "cancel" in the yellow bar (or open the chrome debugger to steal the debugging session) and then go into settings and disable the "Chrome Debugging" provider.

Repros on Chrome 37 (release channel) on linux and mac, seems to NOT repro on Chrome 39 (canary) mac. Haven't tried anything in between yet.

— Reply to this email directly or view it on GitHub https://github.com/google/tracing-framework/issues/517.

rsturgell commented 9 years ago

Yeah, must be something like that. I narrowed it down a bit - if I put alerts around "setElementShown" in SettingsDialog..selectPane:

alert('before'); goog.style.setElementShown(pane.el_, true); alert('after');

I get:

  1. see the "before" alert, click ok
  2. I briefly see a flash of the "after" alert, and then it crashes

So it seems to be there is something async thing that is triggered by showing the settings pane element that crashing while the second alert is up. What code do we trigger when that happens, is there some call into the provider on some dom event or something?

benvanik commented 9 years ago

perhaps an animation issue?