search

google / trajax

Apache License 2.0
186 stars 23 forks source link

Replace deprecated sym_pos and tree_multimap #10

Closed J4nn1K closed 1 year ago

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

J4nn1K commented 1 year ago

jax.tree_multimap was deprecated in JAX version 0.3.5, and removed in JAX version 0.3.16.

stephentu commented 1 year ago

Hi @J4nn1K ,

Thanks for your PR. Internally, we rewrote the tvlqr code a bit so it does not rely on sp.linalg.solve, instead using np.linalg.lstsq, and hence this change is no longer necessary. I am going to close this PR now.