search

google / transitfeed

A Python library for reading, validating, and writing transit schedule information in the GTFS format.
https://github.com/google/transitfeed/wiki
Apache License 2.0
679 stars 254 forks source link

Validation - Catch runtime exception for New Location Type as a error rather than bombing out. #113

Closed bdferris closed 9 years ago

bdferris commented 9 years ago

From clancy.c...@gmail.com on November 10, 2008 03:08:52

If there is a wrong location_type, it should be raised as an error rather than throwing an exception and ending validation.

Original issue: http://code.google.com/p/googletransitdatafeed/issues/detail?id=113

bdferris commented 9 years ago

From tom.brow...@gmail.com on November 10, 2008 11:29:19

Thanks for accepting this. BTW testBadLocationType in test/testtransitfeed attempts to test this         "stops.txt",         "stop_id,stop_name,stop_lat,stop_lon,location_type\n"         "BEATTY_AIRPORT,Airport,36.868446,-116.784582,2\n"         "BULLFROG,Bullfrog,36.88108,-116.81797,notvalid\n"         "STAGECOACH,Stagecoach Hotel,36.915682,-116.751677,\n")

Labels: Language-Python App-FeedValidator Type-Defect

bdferris commented 9 years ago

From clancy.c...@gmail.com on December 15, 2008 11:28:06

http://codereview.appspot.com/11051

Status: Started

bdferris commented 9 years ago

From clancy.c...@gmail.com on December 16, 2008 02:30:36

Fixed and uploaded in r956

Status: Fixed

bdferris commented 9 years ago

From tom.brow...@gmail.com on February 27, 2009 11:29:14

Issue 138 has been merged into this issue.