google / transitfeed

A Python library for reading, validating, and writing transit schedule information in the GTFS format.
https://github.com/google/transitfeed/wiki
Apache License 2.0
679 stars 254 forks source link

add "problems=problems" as an argument of schedule.Validate (). #480

Open kuwayamamasayuki opened 5 years ago

kuwayamamasayuki commented 5 years ago

I wrote an extension. At that time, I implemented my own Schedule class in the form of inheriting transitfeed.Schedule.

Then, some warnings were output to the console instead of the HTML file.

The causes of such events are as follows. In line 592 of feedvalidator.py, schedule.Validate () does not pass the "problems" variable as an argument, so "problems = self.problem_reporter" is executed at line 1336 of the called schedule.py , "problems" variable had been overwritten.

Therefore, I propose to add "problems=problems" as an argument of schedule.Validate ().

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

kuwayamamasayuki commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

jarondl commented 4 years ago

Thank you! this looks correct.