google / transitfeed

A Python library for reading, validating, and writing transit schedule information in the GTFS format.
https://github.com/google/transitfeed/wiki
Apache License 2.0
679 stars 254 forks source link

[python3] Import six, fix urllib, stringio and dircache errors #484

Open avilaton opened 5 years ago

avilaton commented 5 years ago

Hi all, happy father's day in argentina. There was a country wire power outage over here, I used some of the time to hack in this project to move to python3.

Since the first complains from travis on python3 are about urllib2 not existing on python3, I worked first on that. I imported six because we are all grown ups now and I think adding it should be ok with everyone. At least I hope it is.

avilaton commented 5 years ago

I added fixes for StringIO and dircache issues.

jarondl commented 4 years ago

Adding six as a new dependency requires a new release, since it is a breaking change (a user update will cause breakage).

Since I've already merged the StringIO and dircache parts, can you rework the urllib part to use compat.py file? That would be much simpler to merge.