google / transitfeed

A Python library for reading, validating, and writing transit schedule information in the GTFS format.
https://github.com/google/transitfeed/wiki
Apache License 2.0
679 stars 254 forks source link

Fix #467: pass the Google Maps API key to the schedule viewer. #486

Open andrew-hardin opened 5 years ago

andrew-hardin commented 5 years ago

This is a straightforward fix that resolves issue #467 by allowing the GMaps API key to be configured by the Python server.

A related note: the default API key registered to gtfs.schedule.viewer@gmail.com seems to still be valid :+1:

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

andrew-hardin commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

amenk commented 4 years ago

@andrew-hardin The CI fails, do you know why?

andrew-hardin commented 4 years ago

@amenk: not sure why it failed, but I merged the branch with a recent copy of master and the build passed.

answerquest commented 4 years ago

Hi, is this good to go?