Closed pecalleja closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
This is one git commit with 99 files and git status of +29,726 −24,238
I cannot review such a thing. I don't think anyone can read 60K lines of changes.
@avilaton and me started Python3 porting in smaller steps. If you can contribute small, reviewable changes, that would be welcome. Most auto-porting tools (which I assume you used), allow to apply only partial transformations, by choosing which transformers to apply.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
@googlebot I consent.
Sorry for my mistake, I just wanted to help to make this port. How can I fix my mistake? Currently, all tests for Python 3.7 are already running. how can I go forward with the collaboration?
at least can we have a separate branch for python3 support ?
How would we maintain that branch? Do you plan to submit every change to master to this branch too? Let's update master to python3, but piece by piece. See #412
Python3 porting with all tests running ok.