google / transitfeed

A Python library for reading, validating, and writing transit schedule information in the GTFS format.
https://github.com/google/transitfeed/wiki
Apache License 2.0
679 stars 254 forks source link

[python3] small changes porting #494

Closed pecalleja closed 2 years ago

pecalleja commented 4 years ago

fix compatibility problems with python3 in small changes.

markstos commented 3 years ago

What's the status of getting the Python 3 port merged?

markstos commented 3 years ago

I noticed @pecalleja has a "python3" branch in his repo, but this pull request is against his "develop" branch:

https://github.com/pecalleja/transitfeed/compare/develop...pecalleja:python3

Does the develop branch have the most up-to-date that's proposed to be merged?

pecalleja commented 3 years ago

Hi @markstos, I've worked on two different approaches here... the first was the python3 branch in my forked repo https://github.com/pecalleja/transitfeed/tree/python3 . that PR was too big and was rejected https://github.com/google/transitfeed/pull/491 , so I started again from scratch the porting but with a new approach, avoiding auto-porting tools and making small changes in every commit fixing one tests at time. my branch develop is my current working one and it is some commits behind the master version of the upstream repo.

markstos commented 3 years ago

@pecalleja Thanks for your effort.

I see that your carefully crafted re-write of your pull request earned you a year of silence from the maintainers, as if continuing to support Python 2 code was a reasonable option.

markstos commented 3 years ago

Ah, it appears the whole project may be abandoned. The last release was two years ago and last commits were a year ago. Time for someone to fork-and-release if there's interest.

carlfredl commented 3 years ago

👋 Indeed I don't think the Python project here is still active. We're working on a new, Canonical GTFS Validator here https://github.com/MobilityData/gtfs-validator.

markstos commented 3 years ago

@carlfredl Thanks for the link!

pecalleja commented 2 years ago

I'm out