Open pantierra opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
As a follow up - after that had been accepted. I'm happy to do the flake8
cleanup. But maintaining those two things in parallel PRs is too much. Better to go one after another.
We all want to black
this but it is pretty hard to review a +23,671 −20,218 and 88 files changed. Please consider sending smaller changes.
Thank you. How do you want them to be smaller? File by file?
There are no code logic changes in there at all. It is just code formatting. I know it is a lot of lines. But this is the smallest logical piece that I could come up here. Please give me clearer instructions on how to help you with this, and how you want this to become even smaller.
One option for reviewing a change like this would be to run the formatter yourself and diff the result against this PR. That way you're independently confirming that the PR is what it says it is and that there are no additional changes.
Only ran black for better code formatting. No code changes.