`dedup: false` in collection doesn't work?

google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉

Apache License 2.0

504 stars 80 forks source link

`dedup: false` in collection doesn't work? #122

Closed everpeace closed 4 years ago

everpeace commented 4 years ago

I set

collections:
  id: foo
  dedup: false
  rules:
  - rule-a

however, the output of rule rule-a in the collection foo looks like dedeup-ed

Is this behavior expected?

tstromberg commented 4 years ago

Nice find. It seems that the code which checks for the dedup value was dropped during a refactor. I'll send a PR in to address it.

tstromberg commented 4 years ago

Please let me know if #123 fixes this. I'll merge it once confirmed, or some time soon otherwise.

everpeace commented 4 years ago

Thanks for the quick fix! It looks like dedup-ed correctly! but still shows 'previously listed items omitted: ...' message. I think it shouldn't show up here in this case.

tstromberg commented 4 years ago

Fixed. Thank you for your patience!