Make the Tags a set to avoid issues of DeDup

google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉

Apache License 2.0

504 stars 80 forks source link

Make the Tags a set to avoid issues of DeDup #203

Closed MushuEE closed 4 years ago

MushuEE commented 4 years ago

Translated all tags into a set which should remove the need to ever track dupes and or sort by ID

Fix for #196

*I think there are easier ways to solve this but I am learning Go and wanted to use this as an opportunity to get a little better. Not hard feelings if this gets closed! Happy to solve the bug using dedup or another method. I think this is just more resilient long term.

Tested :thumbsup:

MushuEE commented 4 years ago

@tstromberg I saw that you merged a quick fix for tags, would you like me to close this?

tstromberg commented 4 years ago

@MushuEE - Sorry about that. I merged a fix because I had made because I wanted to give more time to consider the implications of changing the data format.

After looking more closely at the code, I like your PR better. Do you mind updating the merge conflict? I'll be able to merge it then.

MushuEE commented 4 years ago

Merge done 👍