google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉
Apache License 2.0
504 stars 80 forks source link

FR: Add GOOS build arg to Dockerfile #212

Closed eddiezane closed 3 years ago

eddiezane commented 3 years ago

The current Dockerfile assumes that you are building the image on the same OS/Arch that you are running it.

In my case I am building the image on macOS and deploying to Linux.

tstromberg commented 3 years ago

@eddiezane - PR's welcome!

I'm no Docker expert, but AFAIK, building a Dockerfile assumes Linux, as it is the only platform which natively supports Docker. On macOS, the Docker commands run within a Linux environment.

eddiezane commented 3 years ago

Safe to close - turned out to be a mistake with my configuration.