google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉
Apache License 2.0
504 stars 80 forks source link

Prevent endless loop of loading same page #214

Closed geekgonecrazy closed 3 years ago

geekgonecrazy commented 3 years ago

When loading up rocketchat/rocket.chat here on github it entered two different endless loops looking at the same page repeatedly. With the addition of these two checks it now loads the entire history successfully.

closes #213

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹī¸ Googlers: Go here for more info.

geekgonecrazy commented 3 years ago

@googlebot I signed it!

mik-laj commented 3 years ago

@geekgonecrazy Thanks! I'm starting to test this change.

mik-laj commented 3 years ago

Does this project have any CI? I cannot see any automatic tests running.

geekgonecrazy commented 3 years ago

I'm not aware of one if so. Thanks for trying and confirming it worked for you 🙏