google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉
Apache License 2.0
504 stars 80 forks source link

Run gofumports -w across code base #225

Closed tstromberg closed 3 years ago

mik-laj commented 3 years ago

Should we add it to static checks to avoid regression?

tstromberg commented 3 years ago

@mik-laj - The static-checks PR is what inspired me to run this. Ideal static checks to run, from my perspective, are gofumports & golangci-lint (as slow as it is).

mik-laj commented 3 years ago

Once my PR is merged I will try to add these checks to the CI. My changes is already quite big and I'd rather not add more lines to it.