search

google / triage-party

🎉 Triage Party: massively multi-player GitHub triage 🎉
Apache License 2.0
504 stars 80 forks source link

panic: nil dereference in GithubProvider.getResponse() #236

Closed briandealwis closed 3 years ago

briandealwis commented 3 years ago 
runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb25f07]
at github.com/google/triage-party/pkg/provider.(*GithubProvider).getResponse (github.go:64)
at github.com/google/triage-party/pkg/provider.(*GithubProvider).IssuesListByRepo (github.go:81)
at github.com/google/triage-party/pkg/hubbub.(*Engine).updateIssues (issue.go:87)
at github.com/google/triage-party/pkg/hubbub.(*Engine).cachedIssues (issue.go:46)
at github.com/google/triage-party/pkg/hubbub.(*Engine).SearchIssues.func1 (search.go:66)

The problem seems to be here: https://github.com/google/triage-party/blob/f6fe36560708d5d59476f570780f7ec59967104c/pkg/provider/github.go#L77-L82 It looks like the go-github returns nil pointers for requests that error.