search

google / trillian

A transparent, highly scalable and cryptographically verifiable data store.
Apache License 2.0
3.56k stars 377 forks source link

PopulateLogTile error in MySQL storage tests #3657

Open robstradling opened 1 month ago

robstradling commented 1 month ago

Here's a snippet from the output of go test -v ./storage/mysql:

=== RUN   TestNodeRoundTrip/store-all-read-all-norevisions
E1028 16:50:59.282101  144538 subtree_cache.go:122] PopulateLogTile(): log repop got: 254 internal nodes, want: 0
=== RUN   TestNodeRoundTrip/store-all-read-all-revisions
E1028 16:50:59.299517  144538 subtree_cache.go:122] PopulateLogTile(): log repop got: 254 internal nodes, want: 0

By trial and error I've found that these PopulateLogTile errors started occurring after this commit. However, that commit's description seems to suggest that it may have only surfaced the issue rather than created it.

rahulmansharamani14 commented 3 weeks ago

Hi @patflynn, I’m interested in working on this issue. Could you please let me know if there are any specific guidelines or pointers to keep in mind? Thank you!

patflynn commented 3 weeks ago

Hi @rahulmansharamani14 ! I'm really happy to see external interest, and we welcome contributions. Be aware that we're working quite hard on Tessera ATM, so depending on the size of PR and the review challenge you may see some delays.

@AlCutter may have some pointers