search

google / trillian

A transparent, highly scalable and cryptographically verifiable data store.
Apache License 2.0
3.54k stars 379 forks source link

Default mysql database name and username are conflict prone #658

Closed AMarcedone closed 3 years ago

AMarcedone commented 7 years ago

The default username and database name for the trillian mysql db are currently both test. This can be confusing and easily cause conflicts with other databases on the host machine. I am happy to submit a pull reques substituting "test:zaphod@tcp(127.0.0.1:3306)/test" with "testTrillianUser:testTrillianUserPwd@tcp(127.0.0.1:3306)/testTrillianDB" (and related changes).

codingllama commented 7 years ago

No objections on my part. I'm not that found on that many things being called "test" either. :)

Ideally, #456 would "solve" this for unit tests. Integration test scripts could have a parameter for the DB URL, which solves the whole user/pass/database/schema issue at once, with the default being whatever Travis needs. That's my 2c, though; not sure where the rest of the team stands.

Martin2112 commented 6 years ago

I don't think we have time to work on this at the moment but don't have objections to changing it and would be willing to take PRs to improve it.