Open maoning opened 6 months ago
flyte has a feature that allows us to push custom Python scripts (without authentication). I can work on this, is this counted as a critical submission(max bounty)?
Hi @secureness,
Yes, if this vulnerability is an RCE and universal to all flyte applications with insecure configurations (not related to specific business logic), then it is counted towards critical rating.
Please make sure the following items are completed before the plugin implementation:
Hi @maoning after hours of working, I successes in setting up a vulnerable instance (which took a lot of time) but the main problem is that we can't write a plugin for the grpc protocol also another problem is we need to serve our exploit file that contains the payload by an HTTP server. I'll choose another plugin to continue working.
Thank you @secureness for the investigation. Could you submit your vulnerable config to google/security-testbeds and document the exploit process here in more details so that if when we make exploit file hosting possible and add a grpc client to Tsunami, you or someone else can continue with the work?
For payload hosting part, I wonder if we could just host it in Tsunami github repo. Let me take a look at grpc client options for Tsunami.
@maoning it would be good if we could host the payload in the tsunami GitHub repo! because they accept an HTTP URL. Also, today I found out that there is grpc-gateway and we can use HTTP requests with JSON body to send requests.
@maoning is there any chance that we wrap the flyte cli in Java? because there are many many http requests and it can be installed simply with pip.
@secureness Does grpc client route also require same number of requests? I think if everything is equal, adding a grpc client to Tsunami could be useful in the long run for other services using grpc protocol.
these days I can see many big applications that use grpc-gateway besides their grpc server, I don't think it is a top priority to have a grpc client embedded in the tsunami security scanner plugin ecosystem.
Does grpc client route also require same number of requests?
yes, the grpc-gateway is the main grpc just wrapped with JSON and HTTP as far as I know. there are nearly 6 sequential requests for creating a new project for the tsunami scanner, and we need around 6 requests to create and run a workflow which is really huge and time-consuming, I'm scared of implementing this plugin.
As adding the cli client increases the complexity of Tsunami deployment, let's put this issue on hold and prioritize other requests for now.
OK, I share the setup guide on the testbed repo.
@maoning,
I've worked with Flyte before and can handle this task. I have researched, It can be implemented without
flyte CLI
Can I go ahead and start?
By the way, I've already completed this pull request: tsunami-security-scanner-plugins#488.
Hi @hayageek, we can discuss it once your queue is empty, thank you!
~tooryx
Hi @hayageek, sorry I missed that this was an AI PRP. You can work on this.
~tooryx
Hi @tooryx , Shall I submit the form https://bughunters.google.com/report/tsunami and start work ?
Hi @hayageek,
Yes, thank you.
~tooryx
@tooryx , I have submitted the report (https://issuetracker.google.com/issues/357557468). I will start the work.
Hi @tooryx , I have created a PR for the issue. https://github.com/google/tsunami-security-scanner-plugins/pull/528
Target platform:
Require further research to identify how an exposed Flyte dashboard can be compromised for RCE.
Please read the rules of engagement first at https://github.com/google/tsunami-security-scanner-plugins/issues/409.