search

google / tsunami-security-scanner-plugins

This project aims to provide a central repository for many useful Tsunami Security Scanner plugins.
Apache License 2.0
860 stars 178 forks source link

Fingerprint, Updater script for flyte console. #471

Closed mr-mosi closed 1 week ago

mr-mosi commented 2 months ago

Hi dear tsunami team,

Regarding to issue #426

Please note that, Flyte project has various products but all of them use flyteconsole as their dashboard. So as we need web fingerprints of this projects I run flyteconsole to get fingerprints. I used released versions because they were the most downloaded. and there is one or two versions which the release version not identical with git version, so they were ignored.

bests.

lokiuox commented 1 month ago

Hi @mr-mosi, thank you for your contribution!

I'm reviewing your plugin, but I noticed that the versions.txt file you supplied only contains 5 versions, up to v1.1.3, which is a release from June 2022. From the GitHub repo and the container registry you're using in your script I can see there are way more releases, and the last tagged docker image is v1.12.0. Is there a reason why all these versions are missing?

As a general rule, the plugin should be able to fingerprint as many versions as possible, especially the latest versions.

mr-mosi commented 1 month ago

Hi @lokiuox thank you for your review!

That's good catch! the version.txt file is wrong and I fix it after this message. I just did test on some versions before and I sent a testing file by mistake. so I must fix fingerprints as well. I will do it soon.

I get versions from this address. and you can check them.

mr-mosi commented 1 month ago

Hi @lokiuox , I fixed version.txt file and updated the fingerprints again. two version v1.10.7 and v1.10.6 are removed because they don't have identical git tag to checkout.

thanks!