google / tsunami-security-scanner

Tsunami is a general purpose network security scanner with an extensible plugin system for detecting high severity vulnerabilities with high confidence.
Apache License 2.0
8.27k stars 889 forks source link

Add the go_package option to the protobuf files #57

Closed schischi closed 3 years ago

schischi commented 4 years ago

This option will soon be required to generate the Go code for the protobuf files. Having valid protobuf files for Go would allow us to write report processors in this language.

See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package

Source .proto files should contain a go_package option specifying the full Go import path for the file. If there is no go_package option, the compiler will try to guess at one. A future release of the compiler will make the go_package option a requirement. The Go package name of generated code will be the last path component of the go_package option.

Test plan: Before: $ protoc vulnerability.proto --go_out=/tmp/ 2020/07/22 14:55:26 WARNING: Missing 'go_package' option in "vulnerability.proto", please specify it with the full Go package path as a future release of protoc-gen-go will require this be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information.

After: $ protoc vulnerability.proto --go_out=/tmp/ $ echo $? 0