search

google / tuple.dart

A library providing a tuple data structure
https://pub.dev/packages/tuple
BSD 2-Clause "Simplified" License
194 stars 26 forks source link

Fix operator== for Tuple7. #14

Closed enetor closed 4 years ago

devoncarew commented 4 years ago

Can you add a test that would have caught this issue?

enetor commented 4 years ago

Sure I can. I will probably have to write tests for tuple3-tuple7 though. The existing test only covers tuple2.

devoncarew commented 4 years ago

Sure I can.

Great, thanks!

enetor commented 4 years ago

I have added tests for all Tuple* classes. PTAL!

enetor commented 4 years ago

Looks like the failure was unrelated:

Installing Dart on linux 0.17s$ curl --connect-timeout 15 --retry 5 https://storage.googleapis.com/dart-archive/channels/dev/release/latest/sdk/dartsdk-linux-x64-release.zip > ${TRAVIS_HOME}/dartsdk.zip curl: (56) GnuTLS recv error (-54): Error in the pull function. The command "curl --connect-timeout 15 --retry 5 https://storage.googleapis.com/dart-archive/channels/dev/release/latest/sdk/dartsdk-linux-x64-release.zip > ${TRAVIS_HOME}/dartsdk.zip" failed and exited with 56 during .

Since I don't have write access to this repo, could you please help and rerun the checks?

devoncarew commented 4 years ago

Since I don't have write access to this repo, could you please help and rerun the checks?

Restarted...

enetor commented 4 years ago

Thanks.

I've reverted the additional changes to tuple.dart. But I kept my unit tests - I think they offer much better coverage than the original version and should be retained. Let me know what you think.