search

google / tuple.dart

A library providing a tuple data structure
https://pub.dev/packages/tuple
BSD 2-Clause "Simplified" License
194 stars 26 forks source link

Update dependencies and switch to nullsafety #24

Closed Wikiwix closed 3 years ago

Wikiwix commented 3 years ago

Due to the nature of the package the actual library code is already nullsafe and unchanged. The only necessary changes are

google-cla[bot] commented 3 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Wikiwix commented 3 years ago

@googlebot I fixed it.

mit-mit commented 3 years ago

cc @kevmoo

kevmoo commented 3 years ago

@mit-mit – should I land this?

mit-mit commented 3 years ago

Yes, I think that would be great. There are fair number of dependencies of this.

kevmoo commented 3 years ago

This is not used by the SDK – but in general we sync to google3 before publishing

On Wed, Nov 25, 2020 at 7:45 AM Michael Thomsen notifications@github.com wrote:

Yes, I think that would be great. There are fair number of dependencies of this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/tuple.dart/pull/24#issuecomment-733786015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEFCSLDI4VWR7DURE3PWLSRURA7ANCNFSM4T56NIFA .

Wikiwix commented 3 years ago

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly. Will you take care or should I make another PR?

kevmoo commented 3 years ago

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly. Will you take care or should I make another PR?

Please do!

Wikiwix commented 3 years ago

@kevmoo Just realised I missed to update the CHANGELOG.md accordingly. Will you take care or should I make another PR?

Please do!

See here: https://github.com/google/tuple.dart/pull/25

Wikiwix commented 3 years ago

@kevmoo Any word on when this will land as a prerelease?

kevmoo commented 3 years ago

I can get this out today!

kevmoo commented 3 years ago

Published!

Wikiwix commented 3 years ago

Nice! Thanks :)