google / turbinia

Automation and Scaling of Digital Forensics Tools
Apache License 2.0
749 stars 162 forks source link

[In progress] Implemented hashed TurbiniaRequest and TurbiniaTask in Redis #1379

Closed Igor8mr closed 5 months ago

Igor8mr commented 1 year ago

Description of the change

I am implementing the TurbiniaRequest hash object in Redis, which stores information about a request. I am also converting the TurbiniaTask objects to hashes, which will make the server more efficient.

Applicable issues

Additional information

Checklist

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

aarontp commented 1 year ago

Thanks @Igor8mr ! Let me know if you want any preliminary feedback, otherwise once you mark it as ready for review we can take a look.

Igor8mr commented 1 year ago

Thanks @Igor8mr ! Let me know if you want any preliminary feedback, otherwise once you mark it as ready for review we can take a look. <

Hey @aarontp, I just finished implementing the TurbiniaRequest and TurbiniaTask, but I still need to do plenty of tests with those and fix some issues, so I think it's better to wait until I mark it as ready. Thank you!

jleaniz commented 9 months ago

hey @Igor8mr - Just checking in to see if you still plan on completing this PR. Otherwise, I'm happy to continue where you left off. Thanks!

Igor8mr commented 8 months ago

Hey @jleaniz, thanks for checking in! Sorry for the delay with the pull request, I have been busy with college recently, so I couldn't finish it yet. The changes are mostly done, with the requests being saved in Redis and the API using it to gather information instead of the tasks, which is faster now. The tasks are also converted to hashes, but the API also works for old tasks that are stored as strings. I just needed to fix an issue making the API not gather the information correctly, which makes it not display anything on the website. I also still need to test it more and create unit tests to see if everything else is working fine. If you can help me with these, that would be great, thanks! I can also join you on a call if you want to so I can explain the code better. Thanks again!

jleaniz commented 8 months ago

Sounds good. I assigned this to myself but we can collaborate on it! I'll ping you on the side if i have any questions. Thanks Igor.

jleaniz commented 8 months ago

@aarontp FYI

Igor8mr commented 8 months ago

Sounds good, thanks! Let me know if you have any questions about the PR. I'll try to make more changes to it as well. Thanks!

aarontp commented 8 months ago

Sounds good, thanks @Igor8mr and @jleaniz !

jleaniz commented 5 months ago

Superseded by #1489