search

google / turbinia

Automation and Scaling of Digital Forensics Tools
Apache License 2.0
731 stars 160 forks source link

Rewrite pinfo.py call #1426

Closed hacktobeer closed 6 months ago

hacktobeer commented 7 months ago

Description of the change

Rewrite the call to pinfo.py from a sys call to a pinfo lib call to prevent issues with parsing the json output.

Applicable issues

Checklist

hacktobeer commented 7 months ago

This of course needs the python plaso libs which we do not install. I am going to park this PR until @jleaniz is back and we moved back to GIFT-PPA.

jleaniz commented 6 months ago

@hacktobeer the tests actually pass, but i think you need to merge with the master branch for some updates to the docs (doc building failed)

jleaniz commented 6 months ago

Never mind, i see what you mean

ModuleNotFoundError: No module named 'plaso'
jleaniz commented 6 months ago

I wonder why this isn't available since poetry installs the plaso python package?

**#33 395.0   • Installing plaso (20230717)**
hacktobeer commented 6 months ago

This has been fixed in another PR without using the plaso python lib but does parse the json taking into account possible error messages.