google / turbinia

Automation and Scaling of Digital Forensics Tools
Apache License 2.0
725 stars 163 forks source link

[FR]: GoogleCloudDisk processing requests should fail sooner for local installs #1471

Open aarontp opened 3 months ago

aarontp commented 3 months ago

What is the feature you are proposing?

Currently a "local" installation of Turbinia will accept a GoogleCloudDisk processing request even if it won't be able to process it and all Tasks will fail with an error similar to Task Result was auto-closed from task executor on <worker name> likely due to previous failures. Previous status: [FileArtifactExtractionTask Task failed with exception: [name 'google_cloud' is not defined]]. It would be nice if either the client rejected this immediately or the API server rejected it when the request was submitted. Previously turbiniactl was able to load the config and determine if the server was a cloud instance or not, but the turbinia-client doesn't necessarily have access to this, so it might need to be done at the API server.

What would this feature improve or what problem would it solve?

This will be much easier for users to understand because a) they see it earlier when the request is made and b) the error can be much clearer as to what the real problem is.

What alternatives have you considered?

n/a

aarontp commented 3 months ago

FYI @jleaniz