Open aarontp opened 7 years ago
Yeah, general unit tests in this case. FWIW, I just checked, and the existing coverage is 26%.
$ coverage run --source turbinia/ run_tests.py
[... snip test output]
TOTAL 1104 814 26%
Coverage has gotten better over time, but should still be higher (not sure what a good target number is). Currently have 54% coverage.
Name Stmts Miss Cover
---------------------------------------------------------
turbinia/__init__.py 4 0 100%
turbinia/celery.py 55 20 64%
turbinia/client.py 144 71 51%
turbinia/config/__init__.py 40 0 100%
turbinia/config/logger.py 32 5 84%
turbinia/evidence.py 109 18 83%
turbinia/jobs/__init__.py 16 1 94%
turbinia/jobs/grep.py 15 2 87%
turbinia/jobs/plaso.py 15 1 93%
turbinia/jobs/psort.py 12 1 92%
turbinia/jobs/strings.py 17 3 82%
turbinia/jobs/worker_stat.py 13 1 92%
turbinia/lib/__init__.py 0 0 100%
turbinia/lib/google_cloud.py 117 74 37%
turbinia/lib/libcloudforensics.py 210 161 23%
turbinia/message.py 49 6 88%
turbinia/output_manager.py 136 72 47%
turbinia/processors/__init__.py 0 0 100%
turbinia/processors/google_cloud.py 66 50 24%
turbinia/processors/mount_local.py 42 32 24%
turbinia/pubsub.py 65 27 58%
turbinia/state_manager.py 125 61 51%
turbinia/task_manager.py 192 135 30%
turbinia/workers/__init__.py 201 15 93%
turbinia/workers/grep.py 23 15 35%
turbinia/workers/plaso.py 21 13 38%
turbinia/workers/psort.py 20 12 40%
turbinia/workers/strings.py 25 16 36%
turbinia/workers/worker_stat.py 14 8 43%
---------------------------------------------------------
TOTAL 1778 820 54%
----------------------------------------------------------------------
Ran 42 tests in 0.653s
Please add celery to the dependencies for testing (see https://github.com/google/turbinia/issues/236)
FWIW, coverage is now a little over 60%, but I'd like it to be at 80% before closing this.
Currently at 69% coverage...
What tests are you referring to? Unit tests?