search

google / turbinia

Automation and Scaling of Digital Forensics Tools
Apache License 2.0
746 stars 163 forks source link

Refactor credentials into recipe globals #926

Open aarontp opened 3 years ago

aarontp commented 3 years ago

Currently credentials are passed around via an attribute on the Evidence objects, but we should probably use the Recipe globals for this so that we can keep all of the data passed around together and have a single way to access it.

aarontp commented 3 years ago

FYI @dfjxs

dfjxs commented 1 year ago

@aarontp

I've started looking into this. Currently, the evidence pre-processors don't have access to the recipe globals. This is why I originally attached the credentials to the evidence item. It made sense to me to do it this way since the credentials apply to the evidence, and generally shouldn't be needed by tasks (with a few exceptions like Plaso).

Having said that, we can make a change to the base worker class to pass the recipe into the evidence pre-processor in evidence_setup, but not sure you still want to do that.

Happy to chat in more detail.