Closed urdeveloper closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Hi Motamedi,
Thanks a lot for your contribution! I will review your changes within next couple of weeks and let you know whether we can merge this pull request.
Best, Andrei
On Fri, Sep 15, 2017 at 12:31 PM, Motamedi notifications@github.com wrote:
The goal of this pull request is to make the necessary changes to the source code/documentation in order to make UniFlow compatible with Polymer 2.x.
You can view, comment on, or merge this pull request online at:
https://github.com/google/uniflow-polymer/pull/12 Commit Summary
- initial polymer 2 upgrade
- Some cleanups
- Update documentation
- Merge pull request #1 from urdeveloper/polymer-2
File Changes
- M README.md https://github.com/google/uniflow-polymer/pull/12/files#diff-0 (119)
- M action-dispatcher.html https://github.com/google/uniflow-polymer/pull/12/files#diff-1 (160)
- M action-emitter.html https://github.com/google/uniflow-polymer/pull/12/files#diff-2 (79)
- M application-state.html https://github.com/google/uniflow-polymer/pull/12/files#diff-3 (277)
- M bower.json https://github.com/google/uniflow-polymer/pull/12/files#diff-4 (22)
- M index.html https://github.com/google/uniflow-polymer/pull/12/files#diff-5 (2)
- M list-view.html https://github.com/google/uniflow-polymer/pull/12/files#diff-6 (246)
- M model-view.html https://github.com/google/uniflow-polymer/pull/12/files#diff-7 (471)
- M state-aware.html https://github.com/google/uniflow-polymer/pull/12/files#diff-8 (222)
- M state-mutator.html https://github.com/google/uniflow-polymer/pull/12/files#diff-9 (63)
- A test-all.html https://github.com/google/uniflow-polymer/pull/12/files#diff-10 (16)
- M test/action-dispatcher_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-11 (69)
- M test/action-emitter_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-12 (59)
- M test/application-state_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-13 (113)
- M test/list-view_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-14 (79)
- M test/model-view_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-15 (117)
- M test/state-aware_test.html https://github.com/google/uniflow-polymer/pull/12/files#diff-16 (32)
- M todomvc/README.md https://github.com/google/uniflow-polymer/pull/12/files#diff-17 (2)
- D todomvc/bower.json https://github.com/google/uniflow-polymer/pull/12/files#diff-18 (21)
- M todomvc/elements/todo-action-dispatcher.html https://github.com/google/uniflow-polymer/pull/12/files#diff-19 (83)
- D todomvc/elements/todo-action-dispatcher.js https://github.com/google/uniflow-polymer/pull/12/files#diff-20 (74)
- M todomvc/elements/todo-app.html https://github.com/google/uniflow-polymer/pull/12/files#diff-21 (71)
- D todomvc/elements/todo-app.js https://github.com/google/uniflow-polymer/pull/12/files#diff-22 (32)
- M todomvc/elements/todo-footer.html https://github.com/google/uniflow-polymer/pull/12/files#diff-23 (54)
- D todomvc/elements/todo-footer.js https://github.com/google/uniflow-polymer/pull/12/files#diff-24 (32)
- M todomvc/elements/todo-header.html https://github.com/google/uniflow-polymer/pull/12/files#diff-25 (84)
- D todomvc/elements/todo-header.js https://github.com/google/uniflow-polymer/pull/12/files#diff-26 (33)
- M todomvc/elements/todo-item.html https://github.com/google/uniflow-polymer/pull/12/files#diff-27 (100)
- D todomvc/elements/todo-item.js https://github.com/google/uniflow-polymer/pull/12/files#diff-28 (66)
- M todomvc/elements/todo-items.html https://github.com/google/uniflow-polymer/pull/12/files#diff-29 (62)
- D todomvc/elements/todo-items.js https://github.com/google/uniflow-polymer/pull/12/files#diff-30 (19)
- M todomvc/elements/todo-styles.html https://github.com/google/uniflow-polymer/pull/12/files#diff-31 (363)
- M todomvc/index.html https://github.com/google/uniflow-polymer/pull/12/files#diff-32 (14)
Patch Links:
- https://github.com/google/uniflow-polymer/pull/12.patch
- https://github.com/google/uniflow-polymer/pull/12.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/uniflow-polymer/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGGYeFkPRu67ceijm4hso_f60iuSu1Aks5sitCkgaJpZM4PZapV .
Thanks again @urdeveloper for your contribution. I reviewed the code and merged your pull request with some minor additions/corrections. Good quality work, really appreciate your help with the project!
-Andrei
The goal of this pull request is to make the necessary changes to the source code/documentation in order to make UniFlow compatible with Polymer 2.x.