google / uniflow-polymer

UniFlow for Polymer
https://google.github.io/uniflow-polymer/
Apache License 2.0
165 stars 21 forks source link

Upgrade UniFlow to Polymer 2.x #12

Closed urdeveloper closed 6 years ago

urdeveloper commented 6 years ago

The goal of this pull request is to make the necessary changes to the source code/documentation in order to make UniFlow compatible with Polymer 2.x.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


urdeveloper commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

militeev commented 6 years ago

Hi Motamedi,

Thanks a lot for your contribution! I will review your changes within next couple of weeks and let you know whether we can merge this pull request.

Best, Andrei

On Fri, Sep 15, 2017 at 12:31 PM, Motamedi notifications@github.com wrote:

The goal of this pull request is to make the necessary changes to the source code/documentation in order to make UniFlow compatible with Polymer 2.x.

You can view, comment on, or merge this pull request online at:

https://github.com/google/uniflow-polymer/pull/12 Commit Summary

  • initial polymer 2 upgrade
  • Some cleanups
  • Update documentation
  • Merge pull request #1 from urdeveloper/polymer-2

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/uniflow-polymer/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGGYeFkPRu67ceijm4hso_f60iuSu1Aks5sitCkgaJpZM4PZapV .

militeev commented 6 years ago

Thanks again @urdeveloper for your contribution. I reviewed the code and merged your pull request with some minor additions/corrections. Good quality work, really appreciate your help with the project!

-Andrei