search

google / universal-dash-transmuxer

UDT (Dash Transmuxer) Project: Can transmux DASH -> HLS or other formats.
http://www.google.com
Apache License 2.0
54 stars 25 forks source link

dash_to_hls_api.cc GetDuration() doesn't fall back to trex box #3

Closed Uragawa closed 8 years ago

Uragawa commented 8 years ago

The duration of a sample should fall back to trex if it isn't specified in trun and a default isn't present in tfhd. Writing the container like that apparently isn't recommended behaviour but it happens in practice.

rbouqueau commented 8 years ago

GPAC/MP4Box maintainer here. The technical explanation at https://github.com/gpac/gpac/issues/234#issuecomment-140026567

justsomeguy-google-com commented 8 years ago

I need a clear sample that shows this problem.

justsomeguy-google-com commented 8 years ago

I have a patch I'll upload later this week. It will check the trex if one exists and there is no duration in the trun or tfhd.

Uragawa commented 8 years ago

As far as I'm concerned this issue can be closed.

joeyparrish commented 8 years ago

From what I can tell, this was fixed at the same time as #4. We can reopen if this is not the case. Thanks, @Uragawa.