google / universal-dash-transmuxer

UDT (Dash Transmuxer) Project: Can transmux DASH -> HLS or other formats.
http://www.google.com
Apache License 2.0
54 stars 25 forks source link

MVHD and MDHD Parsing Errors #9

Closed csloan-gmail closed 8 years ago

csloan-gmail commented 8 years ago

When these boxes have a version == 1 MdhdContents::Parse and MvhdContents::Parse parse the time scale member as 64-bits when it should be 32-bits. Interestingly, the comments before these functions have the proper class definitions from ISO 14496-12 so it just looks like a duplicated typo.

I fixed these locally to get our content parsing properly but we need these changes in future player SDKs. Can someone take a look?

Thanks, Chris

joeyparrish commented 8 years ago

Thanks for the report. We'll take a look and get back to you.

joeyparrish commented 8 years ago

Yes, it definitely looks like a typo.

SeawardT commented 8 years ago

Resolved on v3.0.4 branch. Please feel free to use that for now until we merge.